Avoid creating Strings during distribution gen (WIP)#57
Closed
alamb wants to merge 1 commit intoclflushopt:mainfrom
Closed
Avoid creating Strings during distribution gen (WIP)#57alamb wants to merge 1 commit intoclflushopt:mainfrom
alamb wants to merge 1 commit intoclflushopt:mainfrom
Conversation
alamb
commented
Mar 21, 2025
| pub struct Distribution { | ||
| name: String, | ||
| values: Vec<String>, | ||
| values: Vec<&'static str>, |
Collaborator
Author
There was a problem hiding this comment.
the idea was to not allocate strings
Collaborator
Author
|
This was done for real in #63 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to make the startup time faster and one thing I figured I could do is stop copying strings during text pool generation.
However I made the change to avoid copying and it doesn't really seem to have helped, but I figured I would put up the PR in case someone else was interested
Main
This branch: